make file paths clickable using pattern - #3473
Merged
Merged
Conversation
Contributor
Author
|
Results in this: cc @ad-si |
ad-si
approved these changes
Dec 3, 2018
Member
|
I'm torn on this, since it's definitely less readable, and unless you are already familiar with the format, entirely cryptic. I know it's pretty common, but it always takes me a while to parse it. Perhaps it's more a job for an option with PSA or something? I don't know. |
Contributor
|
If you're reading it, you are already doing something wrong 😅. For me it's just an opaque identifier I click on (or select and paste) to get to the position. This could even be super charged with https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda |
justinwoo
force-pushed
the
clickable-file-paths
branch
from
December 3, 2018 18:53
b8a157b to
89d7e15
Compare
Contributor
Author
|
Now prints this: (both link form and long form) |
gasi
approved these changes
Dec 13, 2018
hdgarrood
approved these changes
Dec 13, 2018
Member
|
Thanks! |
cyrilfretlink
added a commit
to cyrilfretlink/purs-loader
that referenced
this pull request
Mar 4, 2019
cyrilfretlink
added a commit
to cyrilfretlink/purs-loader
that referenced
this pull request
Mar 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on suggestion in #3472