PSCi: Support multiple command types in paste-mode - #3471
Merged
LiamGoodacre merged 1 commit intoDec 15, 2018
Conversation
natefaubion
approved these changes
Dec 11, 2018
natefaubion
left a comment
Contributor
There was a problem hiding this comment.
Seems to do what it says on the tin!
hdgarrood
reviewed
Dec 14, 2018
| _ -> parseRest psciCommand cmdString | ||
|
|
||
| parseRest :: P.TokenParser a -> String -> Either String a | ||
| parseRest :: P.TokenParser a -> String -> Either String [a] |
Contributor
There was a problem hiding this comment.
This PR all looks great but I’m just slightly concerned about this change; I’m not sure it makes sense with all of the use sites. In particular should the places it’s used in parseDirective be changing? Unless I’m missing something, :browse Prelude Control.Bind will now queue two Browse commands, which seems a little odd to me.
Member
Author
There was a problem hiding this comment.
Ah yes, this was unintentional. Thanks!
E.g. you can paste an import and a declaration together: ``` > :paste … import Prelude … foo = true … ^D > ```
Member
Author
|
@hdgarrood I think this is ready to look at again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3454
E.g. you can paste an import and a declaration together:
Before
After