Fix linting of unused type variables - #3464
Merged
LiamGoodacre merged 1 commit intoDec 2, 2018
Merged
Conversation
garyb
approved these changes
Dec 2, 2018
Member
Author
|
Thanks for the review @garyb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3380
The original algorithm didn't appear to be caring about the scope of type variables introduced with
forall- it just asked for "all the type variables" that appear in some type.This PR changes this so it walks the type and respects variable scope.
With the following code:
Output diff (trimmed):
+ Type variable f is ambiguous... Type variable h is ambiguous...