Link to documentation repo as docs for non-Prim built-in types/kinds - #3460
Conversation
- put row's kind signature (# Type) before its example. - lowercase Row to row to not risk implying that it's a name of something in the language - change `functionTypeSignature` to `f` since the meta-language function name is unneeded - change "click here" link text to more appropriate "purescript language reference"
|
This is pretty close to being mergeable now imo, but one last nitpick: I think we should have
instead of
since I think the latter, by using the article the together with i.e. (= that is), implies that |
|
Nitpicks are fine, especially on docs. I'll fix it. |
|
I believe you asked someone in another PR to add their names to the list of contributors. Will that be required of me as well before this gets merged? |
|
Yes please :) |
|
Pushed. Just need to wait on CI then. |
|
Sorry, I should have been a little clearer: I think it would be best to replace the i.e. with an e.g. in addition to pluralising 'row kinds', since I would argue that (even though you've already pluralised 'row kinds') the i.e. still implies that |
|
Oh. No, that's my bad for misreading your feedback. I'll push another commit with that change. |
|
Unrelated to this PR, but I always thought that the row kind was Is that correct? I never see other examples of row kinds, so that's why I've thought that for so long. |
|
Yeah, that is correct. For any kind which has kind which has kind |
|
Thanks! |
Fixes #3459