Added ffiCodegen to MakeActions - #3434
Conversation
|
@kritzcreek I think you will like this change :) |
|
The change to the IDE code is not necessary, because That doesn't mean I'm opposed to this change at all ^^ Just that it's not really doing anything for the ide integration. |
| ma { P.progress = \_ -> pure () } | ||
|
|
||
| -- | Stops any kind of codegen (also silences errors about missing or unused FFI | ||
| -- files though) |
There was a problem hiding this comment.
@kritzcreek I was led by this comment. Anyway, the dictionary lookup should not be very expensive (which is the only overhead added to modules without ffi), checkForeignDecls is though, but it's also useful. As I understand, now ffi errors will magically ;) disappear when a module is rebuild.
There was a problem hiding this comment.
The comment is misleading, yeah. It's technically not wrong, but we don't care about any errors that might be generated here anyway because we've already gotten all the errors and sent them off to the editor at this point. I'd be totally fine if you just ripped the parenthesized part out.
There was a problem hiding this comment.
The first build:
purescript/src/Language/PureScript/Ide/Rebuild.hs
Lines 73 to 74 in fb8daff
doesn't shushCodegen.
|
@kritzcreek I re-started the ci and its green now. |
|
I resolved the conflict introduced by #3433, I'll merge as soon as CI passes. |
|
Thanks! |
There are two reasons for this PR:
zephyrcan useffiCodegento generate ffi codepurs idecan show ffi errors (unused ffi imports)