Skip to content

Remove scripts - #3011

Merged
paf31 merged 1 commit into
masterfrom
phil/no-scripts
Sep 10, 2017
Merged

Remove scripts#3011
paf31 merged 1 commit into
masterfrom
phil/no-scripts

Conversation

@paf31

@paf31 paf31 commented Jul 30, 2017

Copy link
Copy Markdown
Contributor

Breaking, for 0.12.0, fixes #2993

@paf31
paf31 requested a review from hdgarrood July 30, 2017 20:55
hdgarrood
hdgarrood approved these changes Jul 30, 2017
View reviewed changes

@hdgarrood hdgarrood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also, this reminds me that there are a few places in the compiler which refer to the old binaries; I'll try to remember to address that at some point.

Does this mean we aren't going to have any more releases in the 0.11.x series? Not that that's a problem, I'm just wondering.

@garyb

garyb commented Jul 30, 2017

Copy link
Copy Markdown
Member

Does this mean we aren't going to have any more releases in the 0.11.x series? Not that that's a problem, I'm just wondering.

I'm hoping to get source span annotations in for the Expr part of the AST (I'm working on it now, although it won't be finished tonight), as we're missing position info from some errors since I added annotations elsewhere, and then release that as maybe the last 0.11.x. Phil suggested these PRs could either be merged into a branch or hang around until that's done.

@hdgarrood

hdgarrood commented Jul 30, 2017

Copy link
Copy Markdown
Contributor

Ok, cool: in that case can we add the scripts to extra-source-files for the next 0.11.x?

@hdgarrood

hdgarrood commented Aug 1, 2017

Copy link
Copy Markdown
Contributor

Actually, come to think of it, it might be confusing to add them and immediately remove them again, and Homebrew already have a workaround for 0.11.6 which ought to continue to work for 0.11.7.

@actionshrimp actionshrimp mentioned this pull request Aug 19, 2017
Merged
@paf31
paf31 merged commit eb0007d into master Sep 10, 2017
@paf31
paf31 deleted the phil/no-scripts branch September 10, 2017 00:50
@hdgarrood hdgarrood mentioned this pull request Mar 31, 2018
Closed
@hdgarrood hdgarrood mentioned this pull request May 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@hdgarrood hdgarrood hdgarrood approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready for review type: breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate & remove old wrapper scripts

3 participants

@paf31 @garyb @hdgarrood