Warn for shadowed type class variables - #2441
Merged
Merged
Conversation
paf31
reviewed
Nov 19, 2016
| f (PositionedDeclaration pos _ dec) = addHint (PositionedError pos) (f dec) | ||
| f dec@(ValueDeclaration name _ _ _) = addHint (ErrorInValueDeclaration name) (warningsInDecl moduleNames dec <> checkTypeVarsInDecl dec) | ||
| f (TypeDeclaration name ty) = addHint (ErrorInTypeDeclaration name) (checkTypeVars ty) | ||
| f (TypeClassDeclaration name args _ _ decs) = addHint (ErrorInTypeClassDeclaration name) (foldMap (checkTypeVarsInDecl' (S.fromList $ fst <$> args)) decs) |
Contributor
There was a problem hiding this comment.
Does it make sense to call f recursively on the elements of decs here? Then you'd get a ErrorInTypeDeclaration wrapper applied too.
Member
Author
There was a problem hiding this comment.
Probably, though I'm not following how we'd do that. 😄
Contributor
There was a problem hiding this comment.
Oh, I guess we'd need to modify f to add an accumulator parameter then.
Either way, we should probably add an ErrorInTypeDeclaration somehow.
Contributor
|
Looks great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #2140
The error seems less than ideal:
Should we add which type definition is shadowing? If so, how do we nest that properly? Or is this a fine message?