Skip to content

Traversal should pick up bindings in all value declarations. - #2412

Merged
paf31 merged 1 commit into
purescript:masterfrom
LiamGoodacre:fix/value-binder-scope
Nov 7, 2016
Merged

Traversal should pick up bindings in all value declarations.#2412
paf31 merged 1 commit into
purescript:masterfrom
LiamGoodacre:fix/value-binder-scope

Conversation

@LiamGoodacre

Copy link
Copy Markdown
Member

For #2411

I still can't compile due to macOS Sierra 😦 so I'm relying on the build servers to tell me things are okay.

We seem to have lots of problems with these traversal functions.
I might have a play sometime to see if we can structure it in such a way that we can't make a mistake... No idea what that would look like though 😺.

@garyb

garyb commented Oct 30, 2016

Copy link
Copy Markdown
Member

Offtopic, but what's the trouble with Sierra? I updated and haven't had any trouble compiling (with Stack at least).

@LiamGoodacre

Copy link
Copy Markdown
Member Author

I've been getting very strange issues. Currently trying to nuke my ~/.stack and purescript/.stack-work and see if I can do everything from scratch. Issues I've seen include malformed mach-o and ghc: panic! (the 'impossible' happened).

@paf31
paf31 merged commit 887d413 into purescript:master Nov 7, 2016
@paf31

paf31 commented Nov 7, 2016

Copy link
Copy Markdown
Contributor

Thanks!

@LiamGoodacre
LiamGoodacre deleted the fix/value-binder-scope branch November 23, 2016 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants