Fix the duplicate/redefined module error - #2327
Merged
Merged
Conversation
garyb
commented
Sep 24, 2016
| updateEnv :: ([Module], Env) -> Module -> m ([Module], Env) | ||
| updateEnv (ms, env) m@(Module ss _ mn _ refs) = | ||
| case mn `M.lookup` env of | ||
| Just m' -> throwError . errorMessage $ RedefinedModule mn [envModuleSourceSpan m', ss] |
Member
Author
There was a problem hiding this comment.
No need to check if a module already exists in the name environment anymore since it will be caught during Make and the error raised there.
Member
Author
|
Any ideas on why that test would fail on some platforms/configs? 😕 |
Member
Author
|
Hmm, weird, still failing. |
garyb
force-pushed
the
duplicate-module-error
branch
from
September 24, 2016 20:49
b351cc3 to
6fd459e
Compare
Member
Author
|
Ok, we're good now, it was due to missing files in the cabal file. The coverage build is failing due to a dependency issue though... the same is true of |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1828