[psc-ide] Parse type annotations from source files - #2303
Merged
paf31 merged 1 commit intoSep 11, 2016
Conversation
Then use these parsed type annotations to give back the non-expanded types for functions that contain type synonyms in their annotation.
Contributor
|
Looks good to me, thanks! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Then use these parsed type annotations to give back the non-expanded
types for functions that contain type synonyms in their annotation.
Fixes #2302
I didn't add any tests for this yet but it's kind of trivial so I'm willing to accept that for now. The extra information about type annotations is only available on the
typecommand and not thecompletecommand yet, just like with definitions sites. This can definitely be changed but I'll leave that for another PR.