Evaluate PSCi expressions in the browser by paf31 · Pull Request #2199 · purescript/purescript

paf31 · 2016-06-19T05:39:07Z

This is very rough right now, but it works, and here's a demo.

This assumes some client JavaScript code which understands the websocket protocol being used. I put this together as a quick experiment based on the Try PureScript code.

Handle the websocket close event
Limit to a single connected client?
Handle CTRL+C correctly
Add a --browser command line option
Serve static resources using Warp
Avoid sending compiled code over the websocket. The client can load it from the static web server.
Bundle all JS resources on startup
Re-bundle on :reload

Fixes #2142.

cc @artemyarulin I see you've been working on this too. We should combine efforts, if you're interested?

…ockets

paf31 · 2016-06-23T05:09:12Z

@artemyarulin If you're still interested in working on this, I refactored my code to allow for the two backends (see the nodeBackend and browserBackend functions), so it should be possible to port your CLI code to build the Backend from the command line arguments (using either --browser <port> or --node-opts).

If you don't have time, that's totally fine obviously, but I wanted to let you know.

artemyarulin · 2016-06-23T06:13:08Z

Thanks, really nice, I keep eye on everything related to PSCi. Unfortunately I don't have time to work on it now, but I'll try to play with it and report if anything interesting pop up.

artemyarulin · 2016-06-23T09:17:04Z

Just quickly played with remote REPL and it works with React Native just fine, I'm very happy 👍

paf31 · 2016-06-23T16:34:41Z

Alright, that's much cooler than my demo. 😄 I'm glad it worked for you, thank you for testing it out.

garyb · 2016-06-23T16:36:37Z

That's so cool!

paf31 · 2016-06-23T17:18:08Z

+  , "  return buffer.join('\\n');"
+  , "};"
+  , "window.onload = function() {"
+  , "  var socket = new WebSocket('ws://0.0.0.0:9160');"


Must remember to fix this port.

artemyarulin · 2016-06-23T19:39:38Z

Can we put JS/HTML file into separate file? Now editing it is quiet difficult. And would be cool to have auto-reconnect logic

paf31 · 2016-06-23T19:57:00Z

Yes, I think that's a good idea, although the plan was that you wouldn't need to edit the JS/HTML, and would instead edit some foreign module in your project.

paf31 · 2016-06-24T04:57:13Z

I should be able to finish this off tomorrow, but it's pretty much ready for review now.

artemyarulin · 2016-06-24T10:15:05Z

I'm happy to test, just ping me when it's needed. Curious though - why limit client to only one connection? Only for simplicity of the first version?

paf31 · 2016-06-24T15:12:08Z

I thought about allowing multiple connections, but the issue is that I need the browser to return its result for printing, and with multiple connected browsers, that might get confusing. We can look into it later though, it might be interesting for testing out things like webworkers.

paf31 · 2016-06-25T04:36:18Z

Ok, this is ready for review now. I've tested it quite a bit, and it works quite nicely, but any additional testing is definitely appreciated.

@artemyarulin I added support for multiple clients too, although I only show the result from the first browser to respond.

artemyarulin · 2016-06-25T06:44:56Z

Oh, wow, awesome! I'll test it during today/tomorrow

paf31 · 2016-07-02T20:50:10Z

Could someone please review the code here, so that we can try to release it in 0.9.2?

paf31 · 2016-07-02T22:05:39Z

Clearing the Travis cache seems to have fixed the issue, but we might need to keep a separate cache (or periodically clear the existing one) on MacOS.

garyb · 2016-07-02T22:17:25Z

I'm probably not going to have any time to review until later in the week, sorry.

paf31 · 2016-07-02T22:18:58Z

Ok, no worries, thanks.

artemyarulin · 2016-07-03T11:09:49Z

I'm not qualified enough to check the code, but from the actual functionality - everything works just fine.

hdgarrood · 2016-07-03T18:16:17Z

+    length js `seq` return (mid, js)
+  Bundle.bundle input [] Nothing "PSCI"
+
+-- TODO: use JMacro here?


I haven't used JMacro, so I can't speak to its applicability here, but I have used file-embed successfully for this sort of thing before.

hdgarrood · 2016-07-03T18:33:58Z

Looks good! 👍 I just watched the video, this looks really exciting!

paf31 · 2016-07-03T19:38:43Z

@hdgarrood Thanks for the review, I'll polish this up some time this weekend.

paf31 · 2016-07-03T20:42:58Z

@hdgarrood How's this?

kritzcreek · 2016-07-03T21:19:03Z

Code looks good to me! Would be nice if we could figure out how to test this.

hdgarrood · 2016-07-04T03:17:56Z

Looks good. Just checking: are these new files going to be included in source distributions?

paf31 · 2016-07-04T17:39:34Z

@hdgarrood I put them under extra-source-files, so I think so?

hdgarrood · 2016-07-04T19:58:51Z

Yeah, cool, thats what I was imagining. I guess I missed that change in the cabal file the first time I looked.

paf31 · 2016-07-09T18:57:25Z

So shall I merge this then? Maybe we can make a 0.9.2 release soon, with this, @kritzcreek's psc-ide changes, and hopefully fixes for some of the minor issues in the 0.9.2 milestone?

kritzcreek · 2016-07-09T19:13:12Z

I think what we have makes for a pretty nice 0.9.2

* Initial work on evaluating PSCi expressions in the browser using websockets * Use Warp, add shutdown handler * Bundle all JS resources on startup * Refactoring before supporting multiple backends * Tidy up JavaScript component. Return output/exception stack to PSCi. * Refactor to allow different backends * Remove comments * Add port option, fork ping thread * Only allow one client * Support multiple clients, handle reloads * extra-deps * stack.yaml * Implement suggestions: use file-embed, save console.log, use case * Add static files to bundle

Initial work on evaluating PSCi expressions in the browser using webs…

95d2159

…ockets

paf31 added the needs more work label Jun 19, 2016

paf31 added 5 commits June 19, 2016 12:18

Use Warp, add shutdown handler

a5a1618

Bundle all JS resources on startup

c5b6d4e

Refactoring before supporting multiple backends

f70e7eb

Tidy up JavaScript component. Return output/exception stack to PSCi.

db75f9f

Refactor to allow different backends

bfb5e28

Remove comments

da00760

paf31 reviewed Jun 23, 2016
View reviewed changes

paf31 added 2 commits June 23, 2016 21:36

Add port option, fork ping thread

a72cd53

Only allow one client

7c0920d

Support multiple clients, handle reloads

bd44b4b

paf31 added status: ready for review and removed needs more work labels Jun 25, 2016

paf31 added 2 commits June 24, 2016 21:37

extra-deps

4cfcef0

stack.yaml

0780a48

hdgarrood reviewed Jul 3, 2016
View reviewed changes

Implement suggestions: use file-embed, save console.log, use case

01acede

Add static files to bundle

d97ee54

paf31 merged commit 5452688 into master Jul 10, 2016

paf31 deleted the psci-browser branch July 10, 2016 20:43

Uh oh!

Conversation

paf31 commented Jun 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paf31 commented Jun 23, 2016

Uh oh!

artemyarulin commented Jun 23, 2016

Uh oh!

artemyarulin commented Jun 23, 2016

Uh oh!

paf31 commented Jun 23, 2016

Uh oh!

garyb commented Jun 23, 2016

Uh oh!

paf31 Jun 23, 2016

Choose a reason for hiding this comment

Uh oh!

artemyarulin commented Jun 23, 2016

Uh oh!

paf31 commented Jun 23, 2016

Uh oh!

paf31 commented Jun 24, 2016

Uh oh!

artemyarulin commented Jun 24, 2016

Uh oh!

paf31 commented Jun 24, 2016

Uh oh!

paf31 commented Jun 25, 2016

Uh oh!

artemyarulin commented Jun 25, 2016

Uh oh!

paf31 commented Jul 2, 2016

Uh oh!

paf31 commented Jul 2, 2016

Uh oh!

garyb commented Jul 2, 2016

Uh oh!

paf31 commented Jul 2, 2016

Uh oh!

artemyarulin commented Jul 3, 2016

Uh oh!

hdgarrood Jul 3, 2016

Choose a reason for hiding this comment

Uh oh!

hdgarrood commented Jul 3, 2016

Uh oh!

paf31 commented Jul 3, 2016

Uh oh!

paf31 commented Jul 3, 2016

Uh oh!

kritzcreek commented Jul 3, 2016

Uh oh!

hdgarrood commented Jul 4, 2016

Uh oh!

paf31 commented Jul 4, 2016

Uh oh!

hdgarrood commented Jul 4, 2016

Uh oh!

paf31 commented Jul 9, 2016

Uh oh!

kritzcreek commented Jul 9, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

paf31 commented Jun 19, 2016 •

edited

Loading