Switch to stack for CI, resolves #1974 - #2099
Merged
Merged
Conversation
* Remove the stack-nightly.yaml, since it always needs updating. Instead, we pass --resolver=nightly in one of the build jobs to ensure we always have the latest nightly. As an added bonus we no longer have to set the STACK_YAML environment variable on Windows, because stack.yaml is no longer a symlink. * Remove use of cabal-install, which drastically simplifies the CI scripts :) * Use the 'compiler' key in the build matrix as a hack to ensure each build job gets a separate cache. * Add OSX tests. * Add haddock tests, on a separate build job (for speed). * Use separate build jobs for sdist tests (for speed). * Fix binary bundle uploading on Travis * Add binary bundle uploading for OSX.
Contributor
Author
|
Resolves #2034. |
* No longer need to set STACK_YAML on AppVeyor * We should not attempt to run 'strip' on Windows executables * Fix path to bundle creation script
Contributor
Author
|
In case you were wondering, I've canceled the Travis CI build for the second commit. I'm going to restart it when the first one finishes so that it can use the cache. |
Contributor
|
Great work, thanks very much! Just a note: this also seems to remove the |
Contributor
Author
|
👍 , opened #2101 |
|
Changes Unknown when pulling 4e30241 on hdgarrood:stack-travis into * on purescript:0.9*. |
|
Changes Unknown when pulling 4e30241 on hdgarrood:stack-travis into * on purescript:0.9*. |
Contributor
|
So this is ready to merge? |
Contributor
Author
|
I think so. |
Contributor
|
Thanks very much! |
archaeron
pushed a commit
to archaeron/purescript
that referenced
this pull request
Apr 6, 2017
* Switch to stack for CI, resolves purescript#1974 * Remove the stack-nightly.yaml, since it always needs updating. Instead, we pass --resolver=nightly in one of the build jobs to ensure we always have the latest nightly. As an added bonus we no longer have to set the STACK_YAML environment variable on Windows, because stack.yaml is no longer a symlink. * Remove use of cabal-install, which drastically simplifies the CI scripts :) * Use the 'compiler' key in the build matrix as a hack to ensure each build job gets a separate cache. * Add OSX tests. * Add haddock tests, on a separate build job (for speed). * Use separate build jobs for sdist tests (for speed). * Fix binary bundle uploading on Travis * Add binary bundle uploading for OSX. * Update appveyor CI * No longer need to set STACK_YAML on AppVeyor * We should not attempt to run 'strip' on Windows executables * Fix path to bundle creation script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, we pass --resolver=nightly in one of the build jobs to ensure
we always have the latest nightly. As an added bonus we no longer have
to set the STACK_YAML environment variable on Windows, because
stack.yaml is no longer a symlink.
scripts :)
build job gets a separate cache.
Coverage did not work when I was building on Travis with my fork, but I think that was because of an API key environment variable missing, or something like that. So hopefully it should work here.