Marking code with backticks in error messages - #2060

👍

👍 from me too.

Actually I wonder if we could make it a little more type-safe by having markIdent :: Ident -> String and markProperName :: ProperName a -> String, so that you can't accidentally apply either of the mark functions to something that isn't code?

That way, you only need to call one function, too; markIdent ident as opposed to markCode (runIdent ident).

Sort of related, should the following two constructors have Ident arguments instead of String?

What @hdgarrood said (I just didn't have as clear an idea how to fix it) 👍

Also, I don't know what the right answer is here, but it might be worth considering putting the backticks directly into typeAsBox instead of applying this new withBoxBackTicks function everywhere, so that we don't have to worry about accidentally forgetting them whenever we modify functions in this module.

Re: the above suggestion - I'm not sure every name shown in errors comes through with an Ident or ProperName type. I think Sugar.Names does some stuff with strings to avoid having to specify many different error messages that differ by one word.

Ok, then this LGTM.

Could you please reopen this as a PR on the 0.9 branch?

Thanks!