Skip to content

Use generic Literal in the AST - #1917

Merged
garyb merged 1 commit into
masterfrom
literal-refactor
Mar 8, 2016
Merged

Use generic Literal in the AST#1917
garyb merged 1 commit into
masterfrom
literal-refactor

Conversation

@garyb

@garyb garyb commented Mar 3, 2016

Copy link
Copy Markdown
Member

This is something I noticed when working on the pretty printing the other day - I figured the CoreFn handling of this was a bit nicer, and actually since Literal was already parametric it means it was already suited to be used in either place.

@paf31

paf31 commented Mar 3, 2016

Copy link
Copy Markdown
Contributor

👍 Nice!

@texastoland

Copy link
Copy Markdown

Your productivity is unreal 😳

@garyb

garyb commented Mar 3, 2016

Copy link
Copy Markdown
Member Author

@AppShipIt Ah I don't know about that, I'm not as productive as I'd like 😉 - it's pretty easy to do this kind of thing when you're familiar with most of the compiler.

@paf31 what do we want to do about these GHC 8 warnings?

@texastoland

Copy link
Copy Markdown

what do we want to do about these GHC 8 warnings?

@hdgarrood gave his feel in #1913 (comment) too. What are potential downsides of dropping < 7.10?

@paf31 paf31 closed this Mar 8, 2016
@paf31 paf31 reopened this Mar 8, 2016
@garyb
garyb force-pushed the literal-refactor branch from 966606d to 312f367 Compare March 8, 2016 12:07
@hdgarrood

Copy link
Copy Markdown
Contributor

The only downside I can think of is that not as many people will be able to compile psc etc from source. I hope that we can get tooling to a stage where the majority of people don't feel the need to do this, though.

@garyb

garyb commented Mar 8, 2016

Copy link
Copy Markdown
Member Author

I'd be surprised if many people build from source as it is.

@hdgarrood

Copy link
Copy Markdown
Contributor

I use stack to manage mine at the moment, and I think a few others do too. It's marginally easier than downloading a binary bundle, extracting, and copying onto my PATH. stack does take care of installing the right GHC for you anyway, though. I don't really like the npm installer because the wrapper script it uses has caused problems with psci.

@garyb
garyb force-pushed the literal-refactor branch from 312f367 to e5655c8 Compare March 8, 2016 14:19
garyb added a commit that referenced this pull request Mar 8, 2016
@garyb
garyb merged commit 1e696f0 into master Mar 8, 2016
@garyb
garyb deleted the literal-refactor branch March 8, 2016 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants