Specify Options in spec tests using bitflags from_str - #1122
Open
ollpu wants to merge 4 commits into
Open
Conversation
Collaborator
|
Nice! |
Global options can be added to a file by writing on the first line: Parser options: `ENABLE_ABC | ENABLE_XYZ` Further options can be written in the lang string: ```````````````````````````````` example ENABLE_YUV
This should make it easier to find a failing test.
ollpu
force-pushed
the
spec-test-options
branch
from
August 16, 2026 16:11
a120576 to
4fcaa4e
Compare
ollpu
commented
Aug 16, 2026
Comment on lines
23
to
27
| ```````````````````````````````` example | ||
| **このアスタリスクは強調記号として認識されず、そのまま表示されます。**この文のせいで。 | ||
| . | ||
| <p>**このアスタリスクは強調記号として認識されず、そのまま表示されます。**この文のせいで。</p> | ||
| ```````````````````````````````` |
Collaborator
Author
There was a problem hiding this comment.
This one test prevents setting ENABLE_CJK_FRIENDLY_EMPHASIS on the whole file. Should we just move it to regression.txt? No other spec seems to have negative tests like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I feel that the current system where we define ad-hoc test types
example_deflistsetc. and pass those around as booleans is starting reach its limits. Instead, we could usebitflags::parser::from_strto define theOptionsdirectly.For convenience, I added two ways to set options. The effective options are the union of both.
Global options can be added to a file by writing on the first line:
Further options can be written in the lang string:
I also made it so that the test generator
struct Speckeeps track of the current line in the file and names the test likeblockquotes_tags_test_0005_l44, so it's easier to locate.