Skip to content

Add checks for various other float formats.#460

Merged
brian-brazil merged 1 commit intomasterfrom
om-float
Sep 9, 2019
Merged

Add checks for various other float formats.#460
brian-brazil merged 1 commit intomasterfrom
om-float

Conversation

@brian-brazil
Copy link
Copy Markdown
Contributor

Check for new stuff Go added in 1.13, and also
make sure leading 0s are permitted as some users
want to be able to do fixed-size output.

@SuperQ

Copy link
Copy Markdown
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Check for new stuff Go added in 1.13, and also
make sure leading 0s are permitted as some users
want to be able to do fixed-size output.

Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
@brian-brazil brian-brazil merged commit 8601873 into master Sep 9, 2019
@brian-brazil brian-brazil deleted the om-float branch September 9, 2019 10:33
@brian-brazil
Copy link
Copy Markdown
Contributor Author

Tests caught that Python 3 also supported some of this, so fixed that too.

Arfey pushed a commit to Arfey/client_python that referenced this pull request Sep 13, 2019
Check for new stuff Go added in 1.13, and also
make sure leading 0s are permitted as some users
want to be able to do fixed-size output.

Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: misha.gavela <Arfey17.mg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants