Fix twisted test on Python3.4#427
Closed
xavfernandez wants to merge 1 commit intoprometheus:masterfrom
Closed
Conversation
cf twisted/twisted@fc3be69 and twisted/twisted@8a47339 broke Python3.4 between 19.2.0 and 19.2.1 Signed-off-by: Xavier Fernandez <xavier.fernandez@polyconseil.fr>
acd1116 to
4360a9d
Compare
Contributor
Author
|
cc @brian-brazil (with #424) |
Contributor
Author
|
This fixes the failing test of master branch: https://travis-ci.org/prometheus/client_python/builds/542696662 |
Contributor
brian-brazil
left a comment
There was a problem hiding this comment.
Oops, forgot to press Submit on my review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf
twisted/twisted@fc3be69
and twisted/twisted@8a47339 broke Python3.4 between 19.2.0 and 19.2.1
Signed-off-by: Xavier Fernandez xavier.fernandez@polyconseil.fr