Skip to content

Could io.prometheus:simpleclient_hibernate:0.10.1-SNAPSHOT drop off redundant dependencies to loose weight? - #655

Closed
Celebrate-future wants to merge 1 commit into
prometheus:masterfrom
Celebrate-future:master
Closed

Could io.prometheus:simpleclient_hibernate:0.10.1-SNAPSHOT drop off redundant dependencies to loose weight?#655
Celebrate-future wants to merge 1 commit into
prometheus:masterfrom
Celebrate-future:master

Conversation

@Celebrate-future

Copy link
Copy Markdown

@fstab Hi, I am a user of project io.prometheus:simpleclient_hibernate:0.10.1-SNAPSHOT. I found that its pom file introduced 24 dependencies. However, among them, 7 libraries (29%) have not been used by your project (the redundant dependencies are listed below). Reduce these useless dependencies can help prevent conflicts between library versions. MeanWhile, it can minimize the total added size to projects. It can also help enable advanced scenarios for users of your package.
This PR helps io.prometheus:simpleclient_hibernate:0.10.1-SNAPSHOT lose weight :) I have tested the revised configuration in my local environment. It is safe to remove the unused libraries.

Best regards

Redundant dependencies----


org.apache.geronimo.specs:geronimo-jta_1.1_spec:jar:1.1.1:provided
javax.enterprise:cdi-api:jar:1.1-PFD:provided
javax.inject:javax.inject:jar:1:provided
javax.annotation:jsr250-api:jar:1.0:provided
javax.el:el-api:jar:2.2:provided
org.jboss.spec.javax.interceptor:jboss-interceptors-api_1.1_spec:jar:1.0.0.Beta1:provided
xml-apis:xml-apis:jar:1.0.b2:provided

@fstab

fstab commented Apr 26, 2021

Copy link
Copy Markdown
Member

Thanks for the PR. The hibernate dependency has <scope>provided</scope>, meaning that it will not be added to the project's runtime artifact. It's just used at build time to compile the code against the hibernate API. As provided dependencies are not added to the runtime JAR, I would not expect any change in the resulting JAR file or its runtime dependencies.

Do you see any difference in the size of the resulting io.prometheus:simpleclient_hibernate:0.10.1-SNAPSHOT?

@fstab fstab closed this Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants