Skip to content

Removed exception handling (test smell) #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brian-brazil merged 1 commit into from
Aug 13, 2020
Merged

Removed exception handling (test smell) #567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions simpleclient_httpserver/src/test/java/io/prometheus/client/exporter/TestHTTPServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,11 @@ String requestWithCompression(String context, String suffix) throws IOException
return s.hasNext() ? s.next() : "";
}

@Test
public void testUnbound() throws IOException {
@Test(expected = IllegalArgumentException.class)
public void testRefuseUsingUnbound() throws IOException {
CollectorRegistry registry = new CollectorRegistry();
try {
HTTPServer s = new HTTPServer(HttpServer.create(), registry, true);
s.stop();
fail("Should refuse to use an unbound HttpServer");
} catch (IllegalArgumentException expected) {
}
HTTPServer s = new HTTPServer(HttpServer.create(), registry, true);
s.stop();
}

@Test
Expand Down