Skip to content

Handle null values gracefully in DropwizardExports - #352

Merged
brian-brazil merged 1 commit into
prometheus:masterfrom
henri-tremblay:nullvalue
Mar 14, 2018
Merged

Handle null values gracefully in DropwizardExports#352
brian-brazil merged 1 commit into
prometheus:masterfrom
henri-tremblay:nullvalue

Conversation

@henri-tremblay

Copy link
Copy Markdown
Contributor

No description provided.

@brian-brazil brian-brazil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unittest please?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't used.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right

@henri-tremblay

Copy link
Copy Markdown
Contributor Author

Unit test added

@brian-brazil
brian-brazil merged commit 3a5cef6 into prometheus:master Mar 14, 2018
@brian-brazil

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants