Skip to content

HTTP Server: Add support for Gzip Compression + Reuse ByteArray - #291

Merged
brian-brazil merged 2 commits into
prometheus:masterfrom
erebe:master
Sep 13, 2017
Merged

HTTP Server: Add support for Gzip Compression + Reuse ByteArray#291
brian-brazil merged 2 commits into
prometheus:masterfrom
erebe:master

Conversation

@erebe

@erebe erebe commented Sep 7, 2017

Copy link
Copy Markdown
Contributor

Compatible with java 1.6

  • Add support for gzip compression
  • Reuse ByteArray instead of requesting a new one for each request

brian-brazil
brian-brazil reviewed Sep 7, 2017
View reviewed changes

@brian-brazil brian-brazil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to get a chance to review this properly until next week, but this seems fine from a quick look.

Comment thread simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java Outdated

@brian-brazil brian-brazil Sep 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space after if

@erebe

erebe commented Sep 8, 2017

Copy link
Copy Markdown
Contributor Author

Updated for the space, and understood for until next week

@erebe

erebe commented Sep 12, 2017

Copy link
Copy Markdown
Contributor Author

gentle bump

brian-brazil
brian-brazil reviewed Sep 12, 2017
View reviewed changes
Comment thread simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java Outdated

@brian-brazil brian-brazil Sep 12, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd mark this explicitly private

Comment thread simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java Outdated

@brian-brazil brian-brazil Sep 12, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space before :

Comment thread simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java Outdated

@brian-brazil brian-brazil Sep 12, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be safe you should probably split this and then do an equality check

@erebe

erebe commented Sep 12, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Done,
I use String.split even if it use a regex and that's overkill as we use it also in the parseQuery function

@erebe

erebe commented Sep 13, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

/waving

Compliant java 6

❯ find . -name '*.class' -exec file -b '{}' ;
compiled Java class data, version 50.0 (Java 1.6)
compiled Java class data, version 50.0 (Java 1.6)
compiled Java class data, version 50.0 (Java 1.6)
compiled Java class data, version 50.0 (Java 1.6)
compiled Java class data, version 50.0 (Java 1.6)
compiled Java class data, version 50.0 (Java 1.6)

@brian-brazil
brian-brazil merged commit f195003 into prometheus:master Sep 13, 2017
@brian-brazil

brian-brazil commented Sep 13, 2017

Copy link
Copy Markdown
Contributor

Thanks!

@erebe

erebe commented Sep 13, 2017

Copy link
Copy Markdown
Contributor Author

Thank you for your time for the review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@brian-brazil brian-brazil brian-brazil left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erebe @brian-brazil