fix: use correct page id for ProcessPageEditImageSelect modal when editing already inserted image - #330
Open
brttd wants to merge 1 commit into
Open
Conversation
…iting already inserted image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pwimageplugin for InputfieldTinyMCE (when opening the editing modal):This is the wrong way around. If editing an already inserted image, the editing modal (for ProcessPageEditImageSelect) has the page id set to the repeater, instead of which page actually contains the selected image. If an image from another page has been selected and inserted, the editing modal won't work and displays an error saying it can't find the image.
This PR fixes the issue by simply swapping those two checks, so when editing an existing image it will override the repeater page id. When inserting a new image, the repeater page id will still be used.