fix(WireFileTools): remove redundant strpos check in rmdir scandir loop - #326
Open
gebeer wants to merge 3 commits into
Open
fix(WireFileTools): remove redundant strpos check in rmdir scandir loop#326gebeer wants to merge 3 commits into
gebeer wants to merge 3 commits into
Conversation
scandir() returns bare filenames with no slashes, so directory traversal via '..' is impossible. The strpos check incorrectly skips legitimate files whose basenames contain '..', preventing cleanup of temp dirs for images with consecutive dots in their filename (e.g. name.m.d..500x0.jpg). The literal '..' parent dir entry is already handled by $file == '..'. Fixes: processwire/processwire-issues#2191 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WireFileTools::rmdir()line 131 has an overly broadstrposcheck that prevents legitimate files from being deleted during recursive directory removal.scandir()returns bare filenames (no slashes), so directory traversal via..is impossible in this context. The only dangerous entry is the literal'..'string, already handled by$file == '..'.The
strposcheck incorrectly skips any file whose basename contains..(e.g. image resize variants likename.m.d..500x0.jpg), leaving temp dirs permanently un-deletable and causingfiles-errorslog spam on every request.Note: lines 296 and 307 in the same file correctly use only
$file == '..'without thestrposcheck.Reported in: processwire/processwire-issues#2191