Fix ValueError on Windows when config is on different drive than git repo#3660
Closed
avasis-ai wants to merge 1 commit intopre-commit:mainfrom
Closed
Fix ValueError on Windows when config is on different drive than git repo#3660avasis-ai wants to merge 1 commit intopre-commit:mainfrom
avasis-ai wants to merge 1 commit intopre-commit:mainfrom
Conversation
On Windows, os.path.relpath raises ValueError when the path and the current working directory are on different drives. Wrap all relpath calls in try/except to fall back to the absolute path.
Member
|
ai slop is not acceptable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2530
On Windows,
os.path.relpath()raisesValueErrorwhen the target path and the current working directory are on different drives (e.g., config onC:and repo onD:). This wraps allos.path.relpath()calls in_adjust_args_and_chdirwithtry/except ValueError, falling back to the absolute path when conversion is not possible.As discussed in the issue, option 2 (try/except) was preferred by @asottile.