Skip to content

feat(run): warn instead of error when --files is used outside a git repo #3650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vmandela wants to merge 1 commit into from
+11 −1
Closed

feat(run): warn instead of error when --files is used outside a git repo #3650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pre_commit/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from pre_commit.commands.validate_config import validate_config
from pre_commit.commands.validate_manifest import validate_manifest
from pre_commit.error_handler import error_handler
from pre_commit.errors import FatalError
from pre_commit.logging_handler import logging_handler
from pre_commit.store import Store

Expand Down Expand Up @@ -185,7 +186,16 @@ def _adjust_args_and_chdir(args: argparse.Namespace) -> None:
if args.command == 'try-repo' and os.path.exists(args.repo):
args.repo = os.path.abspath(args.repo)

toplevel = git.get_root()
try:
toplevel = git.get_root()
except FatalError:
if args.command == 'run' and args.files:
logger.warning(
'pre-commit is running outside a git repository. '
'Only the files passed via `--files` will be checked.',
)
return
raise
os.chdir(toplevel)

args.config = os.path.relpath(args.config)
Expand Down
Loading