test semicolon positions - #28
Merged
ai merged 3 commits intoFeb 10, 2025
Merged
Conversation
romainmenke
marked this pull request as draft
January 31, 2025 17:55
romainmenke
force-pushed
the
test-semicolon-positions--persistent-wildebeest-51101c3c59
branch
from
January 31, 2025 18:28
aba72cc to
eff73cc
Compare
romainmenke
marked this pull request as ready for review
January 31, 2025 19:19
Member
|
I am back! Thanks! I also updated CI and tooling. |
Contributor
Author
|
Awesome! Thank you 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that PostCSS currently is inconsistent in determining the end positions of nodes in the original source when nodes have a semicolon at the end.
In the first commit I used the values as currently used by PostCSS.
In the second commit I've set the values as what I would expect them to be.