Consider necessary columns from complex arguments when interchanging dataframes - #4324
Merged
Merged
Conversation
guyrosin
force-pushed
the
fix-necessary-columns
branch
from
August 14, 2023 22:03
9aa93e3 to
e2a7cb4
Compare
Collaborator
|
Thanks so much @guyrosin ! Would you add a changelog entry, in a new |
Contributor
Author
|
Done. That's great to hear! Thanks @alexcjohnson for the feedback |
alexcjohnson
approved these changes
Aug 15, 2023
alexcjohnson
left a comment
Collaborator
There was a problem hiding this comment.
💃 Very nice! Thanks again for identifying AND fixing this regression @guyrosin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression from #4286, where only plain string arguments were considered as necessary columns when interchanging dataframes. This PR considers complex arguments as well (such as
hover_data).For example, running the code below resulted in
ValueError: Value of 'hover_data_0' is not the name of a column in 'data_frame'. Expected one of ['petal_length', 'sepal_length'] but received: speciesplotly.graph_objects, my modifications concern thecodegenfiles and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).