Skip to content

Add Quiver and Streamline Functions - #222

Closed
cldougl wants to merge 34 commits into
plotly:masterfrom
cldougl:master
Closed

Add Quiver and Streamline Functions#222
cldougl wants to merge 34 commits into
plotly:masterfrom
cldougl:master

Conversation

@cldougl

@cldougl cldougl commented May 25, 2015

Copy link
Copy Markdown
Member

Quiver function plots velocity vectors and Streamline function plots
streamlines with directional arrows

Quiver function plots velocity vectors and Streamline function plots
streamlines with directional arrows
@chriddyp

Copy link
Copy Markdown
Member

cc @theengineear @etpinard @aneda

Comment thread plotly/tools.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't make numpy a dependency. check out how we do "protected" imports of pandas to get around this

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively, rewrite the numpy functionality in pure python!

Comment thread plotly/tools.py

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job on all the examples \o/

@theengineear

Copy link
Copy Markdown
Contributor

@cldougl Got some more comments for ya! The highest-priority stuff is related to test coverage.

Note, I'm pretty sure this isn't being run by our tests on Circle. Maybe because it's a PR from your fork? That seems strange though... At any rate, once it gets merged in, you might need to update with another PR if master is failing.

Comment thread plotly/tools.py

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring 🐶 says: sometimes it's helpful to give little "titles" to these examples: https://github.com/plotly/python-api/blob/master/plotly/grid_objs/grid_objs.py#L29-L40

So, for yours, it might be:

  • Example 1: Trivial quiver
  • Example 2: Quiver plot using meshgrid
  • Example 3: Styling the quiver plot

@cldougl cldougl closed this Jul 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants