Skip to content

Bugfix: Only add minimum margin-spacing for container referenced components - #6616

Merged
archmoj merged 9 commits into
masterfrom
bugfix/container-ref-margin
Jun 1, 2023
Merged

Bugfix: Only add minimum margin-spacing for container referenced components#6616
archmoj merged 9 commits into
masterfrom
bugfix/container-ref-margin

Conversation

@hannahker

@hannahker hannahker commented May 29, 2023

Copy link
Copy Markdown
Contributor

Minor fix to #6593 and #6589:

  • Only add reservedMargin when autoexpand=true.
  • Only add the minimum reservedMargin amount, accounting for potential margin spacing added manually by the developer.

Desired behaviour is demoed in the div3 example in this CodePen: https://codepen.io/hannahker/pen/wvEZZvN

@hannahker hannahker added the bug something broken label May 29, 2023
@archmoj

archmoj commented May 29, 2023

Copy link
Copy Markdown
Contributor

@hannahker Thanks for the PR.
Please pull origin/master and merge master into this branch so that the tests work.

Comment thread src/plots/plots.js Outdated
Comment thread src/plots/plots.js Outdated
Comment thread src/plots/plots.js Outdated
@archmoj

archmoj commented Jun 1, 2023

Copy link
Copy Markdown
Contributor

💃

@archmoj
archmoj merged commit 7829f2f into master Jun 1, 2023
@archmoj
archmoj deleted the bugfix/container-ref-margin branch June 1, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants