Skip to content

Avoid attaching internal d3 object to the window - #6487

Merged
archmoj merged 2 commits into
masterfrom
avoid-d3-export
Feb 15, 2023
Merged

Avoid attaching internal d3 object to the window#6487
archmoj merged 2 commits into
masterfrom
avoid-d3-export

Conversation

@archmoj

@archmoj archmoj commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

Fixes #6483.
Regression introduced in v2.17.0 bundles.
@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable regression this used to work labels Feb 15, 2023
Comment thread package.json
},
"dependencies": {
"@plotly/d3": "3.8.0",
"@plotly/d3": "3.8.1",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 💃

@archmoj
archmoj merged commit 506ed1c into master Feb 15, 2023
@archmoj
archmoj deleted the avoid-d3-export branch February 15, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken regression this used to work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Since 2.17.0, window.d3 is exported with internal 3.8.0 version preventing loading of external d3 library

2 participants