Simplify tests by dropping shortcut paths & use main webpack config in karma - #6462
Merged
Conversation
- this solves the webpack issue with d3-interpolate when upgrading to v3 - also this way it is easier to find the files using editors e.g. vs-code
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without shortcut paths developers could easily find & open the relevant files in their editors e.g. vs-code.
Also we could use identical webpack
rulesin karma config similar towebpack.config.js.This simplification would also help address a build problem when upgrading
d3-interpolateto v3.cc: @plotly/plotly_js
I'll move forward and merge this PR before opening a PR to upgrade
d3-interpolate.