Skip to content

choroplethmapbox update on select - #6345

Merged
archmoj merged 5 commits into
masterfrom
choroplethmapbox-updateOnSelect
Oct 21, 2022
Merged

choroplethmapbox update on select#6345
archmoj merged 5 commits into
masterfrom
choroplethmapbox-updateOnSelect

Conversation

@archmoj

@archmoj archmoj commented Oct 20, 2022

Copy link
Copy Markdown
Contributor

Fixes #6346
cc: plotly/dash#1097

@celia-plotly I appreciate it if one could test this plotly.js build in a dash app.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Oct 20, 2022
@alexcjohnson

Copy link
Copy Markdown
Collaborator

@archmoj using your new bundle (and the updated app plotly/dash#1097 (comment)) I don't see any console errors, but I also (after clicking the button any number of times) don't the deselected points dim.

@alexcjohnson

Copy link
Copy Markdown
Collaborator

Nice and simple! Can we create a test based on your reproduction in #6346?

@archmoj

archmoj commented Oct 21, 2022

Copy link
Copy Markdown
Contributor Author

Nice and simple! Can we create a test based on your reproduction in #6346?

Done in 464718c.

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good!

@archmoj
archmoj merged commit dacaa59 into master Oct 21, 2022
@archmoj
archmoj deleted the choroplethmapbox-updateOnSelect branch October 21, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selection broken after reacting add another trace on top of choroplethmapbox

2 participants