Propose fixing eslint module to catch calls to Function.apply - #5868
Merged
Conversation
1 task
archmoj
force-pushed
the
eslint-no-new-func-catch-apply
branch
from
July 30, 2021 17:28
6a746de to
d304972
Compare
alexcjohnson
approved these changes
Jul 30, 2021
alexcjohnson
left a comment
Collaborator
There was a problem hiding this comment.
💃 Nice work tracking this back to eslint. Hopefully that'll be merged and published, but we shouldn't wait for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See eslint/eslint#14860
cc: #5865 and #897
@plotly/plotly_js
Please note that the first
publish-disttest failed below with correct error message which was the expected behavior.