improve CONTRIBUTING and describe how to clone from your fork - #5791
Conversation
|
|
||
| ```bash | ||
| git clone https://github.com/plotly/plotly.js.git | ||
| git clone --depth 1 git@github.com:<your-GitHub-username>/plotly.js.git |
There was a problem hiding this comment.
Is --depth 1 important enough to warrant including here? I could imagine it occasionally being dangerous, like if the user wanted to pick up an old branch and complete the work.
Also, in #5780 we talk about origin and upstream, do we want to discuss how to set that up?
There was a problem hiding this comment.
Is
--depth 1important enough to warrant including here? I could imagine it occasionally being dangerous, like if the user wanted to pick up an old branch and complete the work.
I thought it will make it easier for the people to contribute, instead of pulling down the whole history of plotly.js.
Curious to know what @nicolaskruchten thinks here?
There was a problem hiding this comment.
Also, in #5780 we talk about
originandupstream, do we want to discuss how to set that up?
It appears GitHub recently added a new button which made the process of fetching upstream way easier.
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 we could always bikeshed on this, but it's a clear improvement so let's merge!
@plotly/plotly_js