Skip to content

Frames plotschema for plotly.py v2 - #1292

Merged
etpinard merged 2 commits into
masterfrom
schema-plotly.py-2.0
Jan 11, 2017
Merged

Frames plotschema for plotly.py v2#1292
etpinard merged 2 commits into
masterfrom
schema-plotly.py-2.0

Conversation

@etpinard

@etpinard etpinard commented Jan 11, 2017

Copy link
Copy Markdown
Contributor

- 'traces' isn't completely compatible with the current
  'info_array' coerce function.
expect(plotSchema.frames).toBeDefined();
expect(plotSchema.frames.role).toEqual('object');
expect(plotSchema.frames.items.frames_entry).toBeDefined();
expect(plotSchema.frames.items.frames_entry.role).toEqual('object');

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@theengineear

Copy link
Copy Markdown
Contributor

lgtm! 💃

@etpinard
etpinard merged commit 6ebf221 into master Jan 11, 2017
@etpinard
etpinard deleted the schema-plotly.py-2.0 branch January 11, 2017 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants