This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Re-add new tooltip component - #982
Closed
xhluca wants to merge 16 commits into
Closed
Conversation
Removed default props that were not typed
Collaborator
|
@xhlulu please drop package-lock.json from this PR, since you aren't updating package.json. If you do change package.json, note that dash core is now using node 16 / npm 7 |
xhluca
force-pushed
the
tooltip-component-new
branch
from
August 2, 2021 22:34
7c98b61 to
cbfb31e
Compare
Pass a bbox through graph hover data
Author
Sure. I removed the commit that added |
added 10 commits
August 2, 2021 19:09
This is outdated since absolute tooltip improves upon this
Remove some z-index positioning that were not relevant, change the props
It's not clear how those props will be used and could be confusing. It's better to remove them for now and add them later if needed
xhluca
force-pushed
the
tooltip-component-new
branch
from
August 16, 2021 14:40
723be9e to
bbdbbcb
Compare
AbsoluteTooltip.css has been superceded by style jsx
Author
|
@alexcjohnson am I supposed to commit |
Author
|
@alexcjohnson I feel this PR is ready for review. A few questions for review:
|
When loading, the component will display the loading_text, otherwise it will show the props.children
This was referenced Aug 25, 2021
Closed
Collaborator
|
Closing - will remake shortly in the monorepo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an updated attempt for: #940
Note #941 was also added to this PR in 6a18fd9
Related:
TODOs for demo: