Skip to content

Use libonenandone from source#671

Open
ScriptSmith wants to merge 1 commit intopkgcloud:masterfrom
ScriptSmith:master
Open

Use libonenandone from source#671
ScriptSmith wants to merge 1 commit intopkgcloud:masterfrom
ScriptSmith:master

Conversation

@ScriptSmith
Copy link
Copy Markdown

This fixes the 3 vulnerability warnings upon installation that stemmed from liboneandone's incorrect usage of an old mocha version. (see #644)

The package went unmaintained for months, and has only recently merged the old PR which fixed this issue. There hasn't been any activity on their side to publish an updated version to npm. We could wait for a new version to be published, but don't know when that will be (if ever).

It's not ideal to pull the package from its source, but if a new version isn't published to npm, the only alternatives would be to use a forked package, or drop the provider.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 71.391% when pulling 63549f5 on ScriptSmith:master into a86ac18 on pkgcloud:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 71.391% when pulling 63549f5 on ScriptSmith:master into a86ac18 on pkgcloud:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants