Skip to content

Added information for my XFX RMC-1 midi controller. - #44

Closed
AdamFreemer wants to merge 1 commit into
pidcodes:masterfrom
AdamFreemer:master
Closed

Added information for my XFX RMC-1 midi controller.#44
AdamFreemer wants to merge 1 commit into
pidcodes:masterfrom
AdamFreemer:master

Conversation

@AdamFreemer

Copy link
Copy Markdown

Added information for my XFX RMC-1 midi controller.

@Arachnid

Arachnid commented Apr 5, 2015

Copy link
Copy Markdown
Contributor

Thanks for your pull request! However, there are a couple of issues preventing us from issuing you a PID:

  • Your source code does not have any indication of being licensed under an open-source license. At a minimum, you need to check in a LICENSE file or similar to let users know how your code is licensed.
  • The 'org' field in your pid file should specify just the name of your org (eg, 'xfx'), not the whole path.
  • You appear to be using Arduino, which comes with its own PID. Can you clarify what you need a PID for?

@Arachnid Arachnid closed this May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants