Refactor SORT and add SORT_RO command - #2200
Merged
Merged
Conversation
yatsukhnenko
approved these changes
Oct 23, 2022
|
|
||
| /* Not storing */ | ||
| *using_store = 0; | ||
| *ctx = NULL; |
Member
There was a problem hiding this comment.
*ctx already is NULL so you can remove three lines here
| if (version_compare($this->version, "2.5.0") < 0) { | ||
| $this->assertEquals(array_reverse($list), $this->redis->sort('list', ['sort' => 'desc'])); | ||
| } else { | ||
| // TODO rewrite, from 2.6.0 release notes: |
Member
There was a problem hiding this comment.
Could you also add tests here or remove this block?
Member
Author
There was a problem hiding this comment.
I just removed the block. 2.5.0 is absolutely ancient.
michael-grunder
force-pushed
the
issue.2068-sort_ro
branch
from
October 23, 2022 18:42
6f37066 to
cf0244c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2068