Better authorization header handling in AddAuthenticationHeader#91
Merged
Conversation
8954505 to
57ffebe
Compare
asgrim
approved these changes
Nov 15, 2024
| // @todo probably process this better | ||
| $headerParts = explode(':', $v); | ||
| $request = $request->withHeader(trim($headerParts[0]), trim($headerParts[1])); | ||
| $headerParts = array_map('trim', explode(':', $v, 2)); |
There was a problem hiding this comment.
nit: 'trim' can be replaced with trim(...), first callable syntax is available since php 8.1
Member
Author
There was a problem hiding this comment.
That's true! But by using the "string syntax", the callable is resolved at the engine level instead of the language level which can be a bit faster. But if the project coding standards has a rule to use first class callable, let's update this part 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By limiting the number of results that
explode()returns, we're fine dealing with values containing a:. Also, it ease the check of the parts validity as the result is way more deterministic compared to calling toexplode()without limit.