Skip to content

Introduce a new StepMode (#32) - #4

Merged
phisi merged 1 commit into
phisi:masterfrom
halfhp:master
Feb 26, 2017
Merged

Introduce a new StepMode (#32)#4
phisi merged 1 commit into
phisi:masterfrom
halfhp:master

Conversation

@phisi

@phisi phisi commented Feb 26, 2017

Copy link
Copy Markdown
Owner

resync with halfhp/master

* Introduce a new StepMode

Why:
Increment by value -> no good when zooming
Increment by pixel -> no good when zooming
subdivide -> depending on data chooses ticks at wired locations e.g (1.3 , 2.3, 3,3 instead of 1, 2, 3)

Workaround:
When you know your data: supply an array of predefined increments (by value) for StepModel to choose from
to best fit the desired number of lines. For example:
Start zoomed out with ticks every 100 and as you zoom in switch to 50,10,1

* Introduce a new StepMode

Why:
Increment by value -> no good when zooming
Increment by pixel -> no good when zooming
subdivide -> depending on data chooses ticks at wired locations e.g (1.3 , 2.3, 3,3 instead of 1, 2, 3)

Workaround:
When you know your data: supply an array of predefined increments (by value) for StepModel to choose from
to best fit the desired number of lines. For example:
Start zoomed out with ticks every 100 and as you zoom in switch to 50,10,1

* comments

* restore messed up build files

* sanity check for StepModelFit.setSteps
added unit test for StepModelFit
@phisi
phisi merged commit 85aea0e into phisi:master Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant