Finishing Feature installment plans - #15
Merged
calops merged 2 commits intoNov 10, 2021
Merged
Conversation
PhilDL
commented
Aug 5, 2021
Contributor
- Fix object name "intallment_plan"
- Refactor mapper InstallmentPlan data to have APIResource object like Payment
- Adding Schedule APIResource and initializer to map list to list of Schedule(s)
- Add tests notifications treat
- Fix tests to use new APIResource objects
…o feature-installment-plans
calops
suggested changes
Aug 30, 2021
calops
left a comment
Contributor
There was a problem hiding this comment.
Hi, thanks for the contribution!
- Fix object name "intallment_plan" - Refactor mapper InstallmentPlan data to have APIResource object like Payment - Adding Schedule APIResource and initializer to map list to list of Schedule(s) - Add tests notifications treat - Fix tests to use new APIResource objects - Bump version
PhilDL
force-pushed
the
feature-installment-plans
branch
from
August 31, 2021 05:23
f892231 to
c4b4407
Compare
Contributor
Author
|
I've reverted stylistic changes and squashed the commits. |
calops
approved these changes
Sep 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.