Add CSS linting - #72
Open
guillaumevincent wants to merge 1 commit into
Open
Conversation
Member
|
Thanks a lot @guillaumevincent ! I'll test it today |
Author
|
I started small, and will tackle one feature at a time The current test ( |
Member
|
@bleathem this one works for me, can you please review it? @guillaumevincent thanks a lot, I love it! |
Member
|
@guillaumevincent sorry that it took me so long to loop back to this. Bootstrap 4 beta 2 changed to stylelint and I think it's a good move. What do you think? should we follow it and merge a linter here? thanks a lot! |
Author
|
let me update the pull request @andresgalante |
Install ruby scss-lint package. Use the same mechanism as bootstrap.
guillaumevincent
force-pushed
the
master
branch
from
October 30, 2017 10:08
7fd7c5d to
8662b1c
Compare
Author
|
Pull request update, I use stylelint now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install ruby scss-lint package.
Use the same mechanism as bootstrap.
Fixes https://patternfly.atlassian.net/browse/PTNFLY-2422