Masthead - #50
Conversation
…asthead to include "skip to main" link
…ock with conditional icon so that link text can be used as aria-label value for dropdown
andresgalante
left a comment
There was a problem hiding this comment.
@jgiardino I am sure sure I am missing the point but I don't see the point of navlink been a thing by itself, why not adding it under the nav umbrella?
Also, tabs is a nav with a modifier class, so maybe we should consider putting tabs under navigation also like bootstrap does. If this increases the scope of the story and you don't have time to do it, then I can continue with it.
| @@ -0,0 +1,18 @@ | |||
| <ul class="nav {{ulClass}}"> | |||
There was a problem hiding this comment.
I think that ulClass and the other variables referring a type selector are too general. Is this a case to use styleModifier? #51
If it is I can ask Brian to fix our implementation so we can use it.
| } | ||
| } | ||
|
|
||
| .pf-masthead__skip { |
There was a problem hiding this comment.
the skip link is creating horizontal scrolling
There was a problem hiding this comment.
I can't believe I missed that.
|
@jgiardino sorry for not been able to review this :( it's been a month! I don't really understand Thanks a lot! |
https://jgiardino.github.io/patternfly-atomic/?p=viewall-components-masthead
https://jgiardino.github.io/patternfly-atomic/?p=viewall-components-navigation
Updates include:
Still to do:
Questions: