This repository was archived by the owner on Feb 5, 2025. It is now read-only.
fix(loading-state): Import sass for loading-state - #1154
Merged
Conversation
Make sure sass files are properly imported
jeff-phillips-18
approved these changes
Nov 12, 2018
patternfly-build
pushed a commit
that referenced
this pull request
Nov 12, 2018
## [3.57.1](patternfly/patternfly@v3.57.0...v3.57.1) (2018-11-12) ### Bug Fixes * **loading-state:** Import sass for loading-state ([#1154](patternfly/patternfly#1154)) ([7f8fd54](patternfly/patternfly@7f8fd54))
Contributor
|
🎉 This PR is included in version 3.57.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure sass files are properly imported
Description
related to patternfly/patternfly#1152
patternfly-react uses
sassIncludesfrom patternfly/dist/sass,this should ensure that sass files are included in a build and land in the proper place
Changes