Skip to content

fix: update stylelint deps - #8438

Merged
mcoker merged 3 commits into
patternfly:mainfrom
mcoker:update-stylelint-deps
Jun 2, 2026
Merged

fix: update stylelint deps#8438
mcoker merged 3 commits into
patternfly:mainfrom
mcoker:update-stylelint-deps

Conversation

@mcoker

@mcoker mcoker commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Pulls in changes from a PR in the design repo to use rgb() instead of rgba() - fix: update exporter to use rgb over rgba design-tokens#153
  • Updates the stylelint deps to latest, including breaking changes to stylelint 17
  • Adds "stylelint-order" as a dev dependency since it no longer comes with "stylelint-config-recess-order"
  • Removes "stylelint-use-logical-spec" - that's supported natively now with the "property-layout-mappings" rule
  • Updates the following stylelint errors
    • Property order
    • Deprecated rules (clip -> clip-path, word-break -> overflow-wrap, grid-gap -> gap)
    • Disables stylelint for max-selector violations in :is()/where() - pre-existing, but there was a bug with stylelint that prevented them from being detected

BACKSTOP-REPORT.ZIP

Summary by CodeRabbit

  • Style

    • Modernized CSS grid properties across components, replacing legacy syntax with current standards.
    • Updated text-wrapping to use overflow-wrap for improved long-word handling.
    • Refined CSS property ordering for more consistent styling output.
    • Updated Stylelint configuration and plugin set to align linting rules.

  • Accessibility

    • Improved screen-reader utility using a modern clip-path approach.

  • Content

    • Updated an example modal icon in documentation.

@coderabbitai

coderabbitai Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Updates Stylelint config and devDependencies, regenerates theme token files (rgba→rgb), adds targeted stylelint directives, replaces deprecated CSS properties, standardizes overflow-wrap, and reorders related CSS declarations across many SCSS components.

Changes

Stylelint Configuration & CSS Modernization

Layer / File(s) Summary
Stylelint configuration and tooling updates
.stylelintrc, package.json		 Updated Stylelint plugins/rules (removed liberty/use-logical-spec, added property-layout-mappings, nesting-selector-no-missing-scoping-root, no-invalid-position-declaration) and updated/bumped Stylelint-related devDependencies.
Generated token files and color literal conversions
src/patternfly/base/tokens/*		 Regenerated token SCSS files and converted multiple token color literals from rgba(...) to rgb(..., alpha) while updating autogenerated timestamps; mixin signatures unchanged.
Stylelint directive placements
src/patternfly/base/normalize.scss, src/patternfly/base/reset.scss, src/patternfly/components/FormControl/form-control.scss, src/patternfly/components/Popover/popover.scss, src/patternfly/components/Tooltip/tooltip.scss		 Added stylelint-disable selector-max-type/enable pairs around complex selector blocks and switched some arrow selector disable comments from liberty/use-logical-spec to property-layout-mappings.
Modern CSS replacements (gap/page-break/clip)
src/patternfly/..., src/patternfly/sass-utilities/mixins.scss		 Replaced deprecated grid-gap/grid-row-gap/grid-column-gap with gap/row-gap/column-gap, page-break-inside: avoid → break-inside: avoid, and clip usage → clip-path in screen-reader/visible mixins.
Text wrapping standardization
src/patternfly/components/*		 Replaced word-break: break-word / word-wrap: break-word with overflow-wrap: break-word across many components to unify wrapping behavior.
Declaration reordering for animations and visual layering
src/patternfly/components/*		 Moved transform before transition, translate/visibility before transition timing/duration, reordered border/box-shadow before backdrop-filter, and adjusted outline-offset positioning across interactive elements for consistent generated CSS ordering.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

released on @prerelease``

Suggested reviewers

  • lboehling
  • jcmill
  • wise-king-sullyman
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title follows conventional commit format with a 'fix:' prefix and clearly describes the main change: updating stylelint dependencies.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8438.surge.sh

A11y report: https://pf-pr-8438-a11y.surge.sh

@jcmill
jcmill self-requested a review June 2, 2026 16:35
jcmill
jcmill approved these changes Jun 2, 2026
View reviewed changes

@jcmill jcmill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcoker
mcoker merged commit fff5587 into patternfly:main Jun 2, 2026
6 checks passed
@mcoker
mcoker deleted the update-stylelint-deps branch June 2, 2026 18:36
@patternfly-build

patternfly-build commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.6.0-prerelease.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coderabbitai coderabbitai Bot mentioned this pull request Jun 16, 2026
Merged
@Venefilyn Venefilyn mentioned this pull request Jul 8, 2026
Closed
3 tasks
@mcoker mcoker mentioned this pull request Jul 8, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Jul 20, 2026
Open
This was referenced Jul 22, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcmill jcmill jcmill approved these changes

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mcoker @patternfly-build @jcmill