chore(icons): update to rh icons - #8336

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/patternfly/components/DualListSelector/dual-list-selector--actions.hbs`:
- Line 6: The template uses a new icon identifier
"rh-ui-sort-down-large-to-small" via the pfIcon helper which isn't defined in
the icon library and migration is incomplete (old "sort-amount-down" still used
elsewhere); confirm the new icon exists or revert to the existing
"sort-amount-down" identifier, and update all templates consistently (search for
pfIcon usages and replace or add the new identifier). If adding the new icon,
register it in the icon definitions/manifest with the
"rh-ui-sort-down-large-to-small" key and ensure build assets include it; if
reverting, replace the pfIcon call in dual-list-selector--actions.hbs to use
"sort-amount-down" and align other templates (e.g., toolbar-template.hbs) to the
same identifier.

In `@src/patternfly/components/FormControl/form-control-icon.hbs`:
- Line 5: Status and generic icons are using non‑RH names and form-control.hbs
contains redundant hardcoded branches; update form-control-template-status.hbs
to use RH names (rh-ui-check-circle-fill, rh-ui-warning-fill, rh-ui-error-fill)
instead of "check-circle"/"exclamation-triangle"/"exclamation-circle"; verify
and replace generic icons passed via form-control--HasIcon (e.g., "calendar",
"clock", "bell" in FormControl.md) with the proper RH/react‑icons equivalents or
change callers to pass RH names so pfIcon can resolve them; remove the hardcoded
clock/calendar-alt checks and routing in form-control.hbs (the branch that
checks form-control--HasIcon == "clock" or "calendar-alt") so pfIcon is the
single source of truth for rendering icons.

In `@src/patternfly/components/InputGroup/input-group-text.hbs`:
- Around line 16-21: The template currently renders raw "$" and "@" text nodes
inside the input-group text (conditionals input-group-text--HasDollarSignIcon
and input-group-text--HasAtIcon), which will be announced by screen readers; to
preserve the previous decorative behavior wrap those glyphs in an element with
aria-hidden="true" (e.g., replace the bare text inside the input-group__text
output with a span or i element that has aria-hidden="true") so AT ignores them,
or alternatively keep them as bare text only if they are semantically
meaningful; update the branches for input-group-text--HasDollarSignIcon and
input-group-text--HasAtIcon to render an aria-hidden wrapper accordingly.

In `@src/patternfly/components/Label/label-icon--map.hbs`:
- Around line 1-2: Demo call sites are still passing legacy icon names into the
label component (it reads label-icon--value and renders via pfIcon) which
bypasses the component's rh-ui-* fallback mapping; update the demo templates
that call this component (e.g., card-demo--notification-drawer.hbs and
card-template-status.hbs) to replace the legacy names with the rh-ui-*
equivalents: "check-circle" → "rh-ui-check-circle-fill", "info-circle" →
"rh-ui-information-fill", "bell" → "rh-ui-notification-fill",
"exclamation-circle" → "rh-ui-error-fill", "exclamation-triangle" →
"rh-ui-warning-fill"; for "cube" verify whether an rh-ui-* counterpart exists
and if not switch that demo to rely on the component's status-based fallback
mapping instead.

In `@src/patternfly/components/Login/examples/Login.md`:
- Line 142: Remove the accidental literal "test" that follows the helper icon
call in the Login example; locate the template fragment containing the
helper/icon invocation {{pfIcon "rh-ui-error"}} in Login.md and delete the stray
"test" text (and any unintended whitespace) so only the icon helper renders in
the example.

In
`@src/patternfly/components/MultipleFileUpload/multiple-file-upload-title-icon.hbs`:
- Line 5: The title icon call using the pfIcon helper is passing a non-existent
icon name "rh-ui-server-upload-fill" which causes the helper to render a
missing-icon comment; update the pfIcon invocation to use a valid icon from
`@patternfly/react-icons` (e.g., find the correct server/upload icon name or an
existing "rh-ui-*" variant) or replace the string with an available icon name,
and optionally add a safe fallback (e.g., a known icon name) where pfIcon is
called so the title always renders; locate the pfIcon usage in the
MultipleFileUpload title (the pfIcon helper call) and correct the icon
identifier accordingly.

In `@src/patternfly/components/Nav/nav-link-icon.hbs`:
- Around line 5-9: Callers still pass Font Awesome suffixes to the
nav-link--icon parameter but pfIcon expects full Red Hat icon identifiers;
update every use of nav-link--icon (e.g., in the Masthead demo and Navigation
examples) to pass the full RH names that pfIcon will resolve (for example
replace "cube", "folder", "cloud", "code", "home" etc. with their corresponding
rh-... identifiers such as
rh-ui-cube/rh-ui-folder/rh-ui-cloud/rh-ui-code/rh-ui-home as appropriate),
ensuring each template/example that calls {{pfIcon nav-link--icon}} provides the
full icon name so pfIcon can load the correct SVG.

---

Nitpick comments:
In
`@src/patternfly/components/MultipleFileUpload/multiple-file-upload-status-progress-icon.hbs`:
- Line 5: The template
MultipleFileUpload/multiple-file-upload-status-progress-icon.hbs currently
renders a static icon via {{pfIcon "rh-ui-in-progress"}} for active uploads; to
match other components (e.g., file-upload-file-details.hbs) and the
ProgressStepper's IsInProgressAnimate, replace the static icon with the animated
spinner partial (use the {{#> spinner}} partial or the same spinner invocation
used elsewhere) when the file is actively uploading (mirror the logic from
IsInProgressAnimate/IsInProgressAlt if needed), or if the static icon is
intentional, add a comment documenting that choice so future reviewers know it
was deliberate.