chore: update backstop to support addl themes - #8276

backstop_data/engine_scripts/playwright/addGlassThemeClass.js (1)

1-9: Remove this duplicate per-theme script to avoid drift.

This logic is already centralized in backstop_data/engine_scripts/playwright/applyThemeClasses.js (invoked by backstop_data/engine_scripts/playwright/onReady.js). Keeping both paths increases divergence risk.

Proposed cleanup

-// add glass theme class to html tag
-const glassThemeClass = 'pf-v6-theme-glass';
-
-module.exports = async (page, scenario) => {
-  await page.evaluate(() => {
-    const root = document.querySelector('html');
-    root.classList.add('pf-v6-theme-glass');
-  });
-};

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@backstop_data/engine_scripts/playwright/addGlassThemeClass.js` around lines 1
- 9, This file duplicates theme-class logic already centralized in
applyThemeClasses.js; remove the duplicate by deleting addGlassThemeClass.js and
any references to its exported async function or the glassThemeClass constant
(module.exports and glassThemeClass) so the project relies solely on
backstop_data/engine_scripts/playwright/applyThemeClasses.js (already invoked by
onReady.js) for adding theme classes.

backstop.js (1)

6-17: Extract theme-flag parsing into one shared helper.

process.argv parsing is duplicated here and in backstop_data/engine_scripts/playwright/onReady.js (Lines 7-10 there). Centralizing avoids silent drift between output suffix logic and applied classes.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@backstop.js` around lines 6 - 17, Create a shared helper (e.g., export
function getThemeSuffix or parseThemeFlags) that encapsulates the logic that
computes themeParts and themeSuffix based on process.argv flags (isUnified,
isDark, isGlass, isHighContrast) and replace the duplicated code in backstop.js
and backstop_data/engine_scripts/playwright/onReady.js with calls to that
helper; ensure the helper is exported from a common module and imported where
needed so both the suffix generation and applied classes remain identical, and
keep the exact flag names/ordering and returned string format (`''` or `_' +
joined parts`) to maintain existing behavior.

package.json (1)

12-33: Consider adding aggregate theme scripts to reduce maintenance overhead.

These additions are useful, but the matrix is now large. A wrapper like backstop:test:themes / backstop:approve:themes (running the supported combos) would lower drift and make CI intent explicit.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@package.json` around lines 12 - 33, Add aggregate npm scripts that invoke the
existing theme-specific scripts to reduce duplication and ensure CI runs the
intended matrix; create new scripts named backstop:test:themes and
backstop:approve:themes that run the supported combinations (e.g., default,
--dark, --glass, --high-contrast, and the unified variants) by invoking the
existing scripts like backstop:test:dark, backstop:test:glass,
backstop:test:unified, backstop:approve:dark, backstop:approve:glass,
backstop:approve:unified, etc.; implement them either by chaining the existing
npm scripts with && or by using a task runner (npm-run-all) so package.json only
adds the two wrapper entries and does not duplicate individual command strings.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes