Skip to content

fix(glass): remove background from page, updage dark glass bgimage - #8264

Merged
jcmill merged 1 commit into
patternfly:mainfrom
mcoker:issue-8263
Mar 30, 2026
Merged

fix(glass): remove background from page, updage dark glass bgimage#8264
jcmill merged 1 commit into
patternfly:mainfrom
mcoker:issue-8263

Conversation

@mcoker

@mcoker mcoker commented Mar 30, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

fixes #8263

Summary by CodeRabbit

  • Style
    • Enhanced glass-theme support with transparent page backgrounds for improved visual presentation across theme variants.

@coderabbitai

coderabbitai Bot commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 5531c411-35f7-403e-9486-a4f73a3125c3

📥 Commits

Reviewing files that changed from the base of the PR and between 6866c68 and f040bc4.

⛔ Files ignored due to path filters (1)
  • src/patternfly/assets/images/glass-brand-dark.jpg is excluded by !**/*.jpg
📒 Files selected for processing (1)
  • src/patternfly/components/Page/page.scss

Walkthrough

This PR adds glass-theme style overrides to the Page component to set the background color to transparent when the glass theme is active. The override is applied at two selector levels to ensure the background doesn't obscure the glass theme's background image.

Changes

Cohort / File(s) Summary
Page Glass Theme Overrides
src/patternfly/components/Page/page.scss		 Added background-color: transparent override within :root.pf-v6-theme-glass selector at both the .page and pf-root($page) levels to prevent the page background from obscuring the glass theme background image.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • srambach
  • thatblindgeye
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The PR implements the primary requirement from issue #8263 to remove the page component's secondary background color in glass theme; the dark glass background image update appears incomplete based on the file changes. Verify that the dark glass background image has been updated as required by issue #8263, as only the page.scss background removal is evident in the current changes.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows conventional commit format with 'fix' type and descriptive scope, and accurately reflects the main change of removing page background in glass theme.
Out of Scope Changes check ✅ Passed The changes are limited to page.scss and directly address the glass theme background removal requirement from issue #8263.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8264.surge.sh

A11y report: https://pf-pr-8264-a11y.surge.sh

@mcoker
mcoker requested review from jcmill, lboehling and srambach March 30, 2026 15:23
jcmill
jcmill approved these changes Mar 30, 2026
View reviewed changes

@jcmill jcmill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy is good sometimes.

srambach
srambach approved these changes Mar 30, 2026
View reviewed changes

@srambach srambach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L 🧊TM

@jcmill
jcmill merged commit 3fe5740 into patternfly:main Mar 30, 2026
5 checks passed
@patternfly-build

patternfly-build commented Mar 30, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.62 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Apr 3, 2026
Closed
Merged
Merged
Closed
This was referenced Apr 13, 2026
Closed
Merged
This was referenced Apr 29, 2026
Closed
Closed
Merged
This was referenced May 8, 2026
Closed
Open
@coderabbitai coderabbitai Bot mentioned this pull request Jul 17, 2026
Open
This was referenced Jul 22, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srambach srambach srambach approved these changes
@jcmill jcmill jcmill approved these changes
@lboehling lboehling Awaiting requested review from lboehling

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug - Page - background is obscuring glass bgimage, update bgimage

4 participants

@mcoker @patternfly-build @srambach @jcmill