chore: disabled prettier formatting - #8257
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughReplaced specific ignore entries in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.prettierignore (1)
1-1: Consider cleaning up now-dead Prettier tooling paths.Line 1 (
**) disables formatting globally, sopackage.jsonformatscript currently does nothing. Consider removing/updating theformatscript (and possibly theprettierdevDependency) so the disabled state is explicit and not misleading.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.prettierignore at line 1, The .prettierignore currently contains a global glob ("**") which disables Prettier entirely; remove that entry (or delete the .prettierignore file) and then update the package.json "format" script and the "prettier" devDependency to reflect the desired state—either restore formatting by ensuring .prettierignore no longer blocks files and keep the "format" script and devDependency, or explicitly disable formatting by removing/updating the "format" script in package.json and uninstalling the "prettier" devDependency so the disabled state is not misleading.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.prettierignore:
- Line 1: The .prettierignore currently contains a global glob ("**") which
disables Prettier entirely; remove that entry (or delete the .prettierignore
file) and then update the package.json "format" script and the "prettier"
devDependency to reflect the desired state—either restore formatting by ensuring
.prettierignore no longer blocks files and keep the "format" script and
devDependency, or explicitly disable formatting by removing/updating the
"format" script in package.json and uninstalling the "prettier" devDependency so
the disabled state is not misleading.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: d00d799f-9e7a-4758-94b3-cc6f15d56acf
📒 Files selected for processing (2)
.prettierignore.prettierrc
|
Preview: https://pf-pr-8257.surge.sh A11y report: https://pf-pr-8257-a11y.surge.sh |
| @@ -1,2 +1 @@ | |||
| package.json | |||
| scripts/template/ | |||
| ** | |||
There was a problem hiding this comment.
Do we want to match every file in the current directory and explicitly match every file with an extension just to be safe (like .js, .json, .md and so on)? Might be redundant.
ex:
*
*.*
|
🎉 This PR is included in version 6.5.0-prerelease.62 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Disables prettier. If you have prettier installed, it's causing updates like these, which we don't want - cf79ab3
Summary by CodeRabbit